RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 23:28:12 +00:00
Code Issues Activity Actions

LibWeb: Don't get impl in document_tree_child_browsing_context_count

Browse source 
This caused `Object.getOwnPropertyNames(window)` to throw, as the
`this` value is `Object`.

All users of document_tree_child_browsing_context_count call it on an
existing Window impl, including WP::internal_own_property_keys, so
getting the impl from the JS VM is not necessary.
This commit is contained in:
Luke Wilde 2022-10-20 16:53:29 +01:00 • committed by Andreas Kling
parent 9abe3b0db5
commit 645a64ef0f
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -1040,10 +1040,8 @@ JS_DEFINE_NATIVE_FUNCTION(Window::btoa)
// https://html.spec.whatwg.org/multipage/window-object.html#number-of-document-tree-child-browsing-contexts // https://html.spec.whatwg.org/multipage/window-object.html#number-of-document-tree-child-browsing-contexts
JS::ThrowCompletionOr<size_t> Window::document_tree_child_browsing_context_count() const JS::ThrowCompletionOr<size_t> Window::document_tree_child_browsing_context_count() const
{ {
auto* impl = TRY(impl_from(vm()));
// 1. If W's browsing context is null, then return 0. // 1. If W's browsing context is null, then return 0.
auto* this_browsing_context = impl->associated_document().browsing_context(); auto* this_browsing_context = associated_document().browsing_context();
if (!this_browsing_context) if (!this_browsing_context)
return 0; return 0;