RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 21:05:07 +00:00
Code Issues Activity Actions

WindowServer: Menu::popup() should return when the menu is empty

Browse source 
Previously the WindowServer would assert `!is_empty()` and crash.

Fixes #1689
This commit is contained in:
Brendan Coles 2020-04-07 17:59:48 +00:00 • committed by Andreas Kling
parent 3e677fd03d
commit 6476f690fe
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Servers/WindowServer/Menu.cpp
View file

@ -519,7 +519,10 @@ void Menu::redraw_if_theme_changed()
void Menu::popup(const Gfx::Point& position, bool is_submenu) void Menu::popup(const Gfx::Point& position, bool is_submenu)
{ {
ASSERT(!is_empty()); if (is_empty()) {
dbg() << "Menu: Empty menu popup";
return;
}
auto& window = ensure_menu_window(); auto& window = ensure_menu_window();
redraw_if_theme_changed(); redraw_if_theme_changed();