RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

ProfileViewer: Symbolicate kernel addresses when possible

Browse source 
ProfileViewer will now attempt to open /boot/kernel and use that to
symbolicate kernel addresses (anything above the 3GB mark.)

In other words, if you run ProfileViewer as root, on a profile that
was generated by root, you can now see kernel functions properly
as well. This is not available to non-privileged users.
This commit is contained in:
Andreas Kling 2020-02-22 10:06:33 +01:00
parent 983b4bd9f2
commit 647d0b9e0f
1 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
DevTools/ProfileViewer/Profile.cpp
View file

@ -67,7 +67,6 @@ Profile::Profile(const JsonArray& json)
sample.ptr = sample_object.get("ptr").to_number<u32>(); sample.ptr = sample_object.get("ptr").to_number<u32>();
} }
auto frames_value = sample_object.get("frames"); auto frames_value = sample_object.get("frames");
auto& frames_array = frames_value.as_array(); auto& frames_array = frames_value.as_array();
@ -214,6 +213,11 @@ OwnPtr<Profile> Profile::load_from_perfcore_file(const StringView& path)
auto elf_loader = make<ELFLoader>(static_cast<const u8*>(elf_file.data()), elf_file.size()); auto elf_loader = make<ELFLoader>(static_cast<const u8*>(elf_file.data()), elf_file.size());
MappedFile kernel_elf_file("/boot/kernel");
OwnPtr<ELFLoader> kernel_elf_loader;
if (kernel_elf_file.is_valid())
kernel_elf_loader = make<ELFLoader>(static_cast<const u8*>(kernel_elf_file.data()), kernel_elf_file.size());
auto events_value = object.get("events"); auto events_value = object.get("events");
if (!events_value.is_array()) if (!events_value.is_array())
return nullptr; return nullptr;
@ -239,7 +243,20 @@ OwnPtr<Profile> Profile::load_from_perfcore_file(const StringView& path)
for (auto& frame : stack_array.values()) { for (auto& frame : stack_array.values()) {
auto ptr = frame.to_number<u32>(); auto ptr = frame.to_number<u32>();
u32 offset = 0; u32 offset = 0;
auto symbol = elf_loader->symbolicate(ptr, &offset); String symbol;
if (ptr >= 0xc0000000) {
if (kernel_elf_loader) {
symbol = kernel_elf_loader->symbolicate(ptr, &offset);
} else {
symbol = "??";
}
} else {
symbol = elf_loader->symbolicate(ptr, &offset);
}
if (symbol == "??")
symbol = String::format("%#08x", ptr);
JsonObject frame_object; JsonObject frame_object;
frame_object.set("address", ptr); frame_object.set("address", ptr);