RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

UserspaceEmulator: Skip destroying the Emulator object on shutdown

Browse source 
There are some destruction order races that can cause hangs while
shutting down UE. Since there's no particular value right now in
destroying the Emulator object properly, just avoid destruction and
add a FIXME about looking into it later.
This commit is contained in:
Andreas Kling 2020-11-14 23:39:44 +01:00
parent b5b535aa81
commit 647e92b74f
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
DevTools/UserspaceEmulator/main.cpp
View file

@ -68,7 +68,8 @@ int main(int argc, char** argv, char** env)
environment.append(env[i]);
}
UserspaceEmulator::Emulator emulator(arguments, environment, move(elf));
// FIXME: It might be nice to tear down the emulator properly.
auto& emulator = *new UserspaceEmulator::Emulator(arguments, environment, move(elf));
if (!emulator.load_elf())
return 1;