RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 19:37:35 +00:00
Code Issues Activity Actions

LibWeb: Parse :host() selector

Browse source 
We were already parsing non-function-syntax :host, so let's also do
the :host(...) variant. Note that we don't have matching for these yet.

This fixes many issues on sites generated by Wix, as they often have
selector lists that include some :host() selector, and we'd reject the
entire rule after failing to parse it.
This commit is contained in:
Andreas Kling 2023-08-05 11:51:31 +02:00
parent ac2d9d9273
commit 64c06c345e
4 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Tests/LibWeb/Layout/expected/css-host-selector-gets-parsed.txt Normal file
View file

@ -0,0 +1,14 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: not-inline
BlockContainer <div> at (8,8) content-size 100x100 children: inline
line 0 width: 26.953125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [8,8 26.953125x17.46875]
"whf"
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x100]
PaintableWithLines (BlockContainer<DIV>) [8,8 100x100]
TextPaintable (TextNode<#text>)

9
Tests/LibWeb/Layout/input/css-host-selector-gets-parsed.html Normal file
View file

@ -0,0 +1,9 @@
<style>
:host, div {
width: 100px;
}
:host(span), div {
height: 100px;
background: green;
}
</style><div>whf

11
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -613,6 +613,17 @@ Parser::ParseErrorOr<Selector::SimpleSelector> Parser::parse_pseudo_simple_selec
.argument_selector_list = move(not_selector) } .argument_selector_list = move(not_selector) }
}; };
} }
if (pseudo_function.name().equals_ignoring_ascii_case("host"sv)) {
auto function_token_stream = TokenStream(pseudo_function.values());
auto host_selector = TRY(parse_a_selector_list(function_token_stream, SelectorType::Standalone));
return Selector::SimpleSelector {
.type = Selector::SimpleSelector::Type::PseudoClass,
.value = Selector::SimpleSelector::PseudoClass {
.type = Selector::SimpleSelector::PseudoClass::Type::Host,
.argument_selector_list = move(host_selector) }
};
}
if (pseudo_function.name().equals_ignoring_ascii_case("lang"sv)) { if (pseudo_function.name().equals_ignoring_ascii_case("lang"sv)) {
if (pseudo_function.values().is_empty()) { if (pseudo_function.values().is_empty()) {
dbgln_if(CSS_PARSER_DEBUG, "Empty :lang() selector"); dbgln_if(CSS_PARSER_DEBUG, "Empty :lang() selector");

1
Userland/Libraries/LibWeb/Dump.cpp
View file

@ -574,6 +574,7 @@ void dump_selector(StringBuilder& builder, CSS::Selector const& selector)
builder.join(',', pseudo_class.languages); builder.join(',', pseudo_class.languages);
builder.append(')'); builder.append(')');
} else if (pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Not } else if (pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Not
|| pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Host
|| pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Is || pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Is
|| pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Where) { || pseudo_class.type == CSS::Selector::SimpleSelector::PseudoClass::Type::Where) {
builder.append("(["sv); builder.append("(["sv);