From 64ce453050578216b985f98d8b95bcfdabe030ef Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 20 Oct 2019 09:18:46 +0200 Subject: [PATCH] LibHTML: Only actually-linked elements should be blue+underlined Turns out this just needed a little push in the selector engine. :^) --- Libraries/LibHTML/CSS/Default.css | 2 +- Libraries/LibHTML/CSS/SelectorEngine.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Libraries/LibHTML/CSS/Default.css b/Libraries/LibHTML/CSS/Default.css index 02aaaadd01..71bde27c4f 100644 --- a/Libraries/LibHTML/CSS/Default.css +++ b/Libraries/LibHTML/CSS/Default.css @@ -89,7 +89,7 @@ li { margin-bottom: 2; } -a { +a:link { color: -libhtml-link; text-decoration: underline; } diff --git a/Libraries/LibHTML/CSS/SelectorEngine.cpp b/Libraries/LibHTML/CSS/SelectorEngine.cpp index e8a55c94b1..56ad75c050 100644 --- a/Libraries/LibHTML/CSS/SelectorEngine.cpp +++ b/Libraries/LibHTML/CSS/SelectorEngine.cpp @@ -20,7 +20,8 @@ bool matches(const Selector::Component& component, const Element& element) case Selector::Component::PseudoClass::None: break; case Selector::Component::PseudoClass::Link: - ASSERT_NOT_REACHED(); + if (!element.is_link()) + return false; break; case Selector::Component::PseudoClass::Hover: if (!matches_hover_pseudo_class(element))