mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 00:47:45 +00:00
Revert "Kernel: Prevent VMWareMouseDevice from handling invalid mouse packets"
This reverts commit 4131b35851
.
We're swallowing way too many mouse events from QEMU with this code
enabled. Something is not right, so let's revert it for now.
This commit is contained in:
parent
82d7934959
commit
652042e680
1 changed files with 1 additions and 8 deletions
|
@ -25,11 +25,10 @@ UNMAP_AFTER_INIT RefPtr<VMWareMouseDevice> VMWareMouseDevice::try_to_initialize(
|
||||||
return {};
|
return {};
|
||||||
}
|
}
|
||||||
|
|
||||||
void VMWareMouseDevice::irq_handle_byte_read(u8 byte)
|
void VMWareMouseDevice::irq_handle_byte_read(u8)
|
||||||
{
|
{
|
||||||
VERIFY(VMWareBackdoor::the());
|
VERIFY(VMWareBackdoor::the());
|
||||||
VERIFY(VMWareBackdoor::the()->vmmouse_is_absolute());
|
VERIFY(VMWareBackdoor::the()->vmmouse_is_absolute());
|
||||||
|
|
||||||
// We won't receive complete packets with the backdoor enabled,
|
// We won't receive complete packets with the backdoor enabled,
|
||||||
// we will only get one byte for each event, which we'll just
|
// we will only get one byte for each event, which we'll just
|
||||||
// discard. If we were to wait until we *think* that we got a
|
// discard. If we were to wait until we *think* that we got a
|
||||||
|
@ -37,12 +36,6 @@ void VMWareMouseDevice::irq_handle_byte_read(u8 byte)
|
||||||
// because we wouldn't read the appropriate number of mouse
|
// because we wouldn't read the appropriate number of mouse
|
||||||
// packets from VMWareBackdoor.
|
// packets from VMWareBackdoor.
|
||||||
auto mouse_packet = VMWareBackdoor::the()->receive_mouse_packet();
|
auto mouse_packet = VMWareBackdoor::the()->receive_mouse_packet();
|
||||||
|
|
||||||
// Only process packets with bit 3 set.
|
|
||||||
// Note that this needs to happen _after_ invoking receive_mouse_packet() above
|
|
||||||
if (!(byte & 0x8))
|
|
||||||
return;
|
|
||||||
|
|
||||||
if (mouse_packet.has_value()) {
|
if (mouse_packet.has_value()) {
|
||||||
m_entropy_source.add_random_event(mouse_packet.value());
|
m_entropy_source.add_random_event(mouse_packet.value());
|
||||||
{
|
{
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue