From 6523f03d47a0e4483c6f27bb134447609641d6a9 Mon Sep 17 00:00:00 2001 From: Marcus Nilsson Date: Thu, 13 Jan 2022 16:27:29 +0100 Subject: [PATCH] LibGfx: Change return type of Adler32 checksums in PNGWriter The two Adler32 checksums are u16 and these two getters were mistakenly left as u32 when PNGChunk::add_as_big_endian() was templated leading to corrupted IDAT fields in our PNGs. --- Userland/Libraries/LibGfx/PNGWriter.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibGfx/PNGWriter.cpp b/Userland/Libraries/LibGfx/PNGWriter.cpp index 31dfd68bea..5ca0f43c2d 100644 --- a/Userland/Libraries/LibGfx/PNGWriter.cpp +++ b/Userland/Libraries/LibGfx/PNGWriter.cpp @@ -51,8 +51,8 @@ public: void finalize(PNGChunk&); void add_byte_to_block(u8 data, PNGChunk&); - u32 adler_s1() const { return m_adler_s1; } - u32 adler_s2() const { return m_adler_s2; } + u16 adler_s1() const { return m_adler_s1; } + u16 adler_s2() const { return m_adler_s2; } private: void add_block_to_chunk(PNGChunk&, bool);