RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibProtocol: Add a Download object so users don't have to manage ID's

Browse source 
LibProtocol::Client::start_download() now gives you a Download object
with convenient hooks (on_finish & on_progress).

Also, the IPC handshake is snuck into the Client constructor, so you
don't need to perform it after instantiating a Client.

This makes using LibProtocol much more pleasant. :^)
This commit is contained in:
Andreas Kling 2019-11-24 13:20:44 +01:00
parent 3dc87be891
commit 653e61d9cf
6 changed files with 112 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

38
Libraries/LibProtocol/Download.cpp Normal file
View file

@ -0,0 +1,38 @@
#include <LibC/SharedBuffer.h>
#include <LibProtocol/Client.h>
#include <LibProtocol/Download.h>
namespace LibProtocol {
Download::Download(Client& client, i32 download_id)
: m_client(client.make_weak_ptr())
, m_download_id(download_id)
{
}
bool Download::stop()
{
return m_client->stop_download({}, *this);
}
void Download::did_finish(Badge<Client>, bool success, u32 total_size, i32 shared_buffer_id)
{
if (!on_finish)
return;
ByteBuffer payload;
RefPtr<SharedBuffer> shared_buffer;
if (success && shared_buffer_id != -1) {
shared_buffer = SharedBuffer::create_from_shared_buffer_id(shared_buffer_id);
payload = ByteBuffer::wrap(shared_buffer->data(), total_size);
}
on_finish(success, payload, move(shared_buffer));
}
void Download::did_progress(Badge<Client>, u32 total_size, u32 downloaded_size)
{
if (on_progress)
on_progress(total_size, downloaded_size);
}
}