RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

LibWeb: Use fill_path() to paint <video> play buttons

Browse source 
With this, the play button is nicely antialiased.
This commit is contained in:
MacDue 2023-06-10 00:01:18 +01:00 • committed by Andreas Kling
parent 23f6674301
commit 656f72adc0
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp
View file

@ -204,6 +204,17 @@ void VideoPaintable::paint_loaded_video_controls(PaintContext& context, HTML::HT
control_box_rect.take_from_left(playback_padding); control_box_rect.take_from_left(playback_padding);
} }
static void fill_triangle(Gfx::Painter& painter, Gfx::IntPoint location, Array<Gfx::IntPoint, 3> coordinates, Color color)
{
Gfx::AntiAliasingPainter aa_painter { painter };
Gfx::Path path;
path.move_to((coordinates[0] + location).to_type<float>());
path.line_to((coordinates[1] + location).to_type<float>());
path.line_to((coordinates[2] + location).to_type<float>());
path.close();
aa_painter.fill_path(path, color, Gfx::Painter::WindingRule::EvenOdd);
}
DevicePixelRect VideoPaintable::paint_control_bar_playback_button(PaintContext& context, HTML::HTMLVideoElement const& video_element, DevicePixelRect control_box_rect, Optional<DevicePixelPoint> const& mouse_position) const DevicePixelRect VideoPaintable::paint_control_bar_playback_button(PaintContext& context, HTML::HTMLVideoElement const& video_element, DevicePixelRect control_box_rect, Optional<DevicePixelPoint> const& mouse_position) const
{ {
auto maximum_playback_button_size = context.rounded_device_pixels(15); auto maximum_playback_button_size = context.rounded_device_pixels(15);
@ -231,7 +242,7 @@ DevicePixelRect VideoPaintable::paint_control_bar_playback_button(PaintContext&
{ 0, static_cast<int>(playback_button_size) }, { 0, static_cast<int>(playback_button_size) },
} }; } };
context.painter().draw_triangle(playback_button_location.to_type<int>(), play_button_coordinates, playback_button_color); fill_triangle(context.painter(), playback_button_location.to_type<int>(), play_button_coordinates, playback_button_color);
} else { } else {
DevicePixelRect pause_button_left_rect { DevicePixelRect pause_button_left_rect {
playback_button_location, playback_button_location,
@ -344,7 +355,7 @@ void VideoPaintable::paint_placeholder_video_controls(PaintContext& context, Dev
Gfx::AntiAliasingPainter painter { context.painter() }; Gfx::AntiAliasingPainter painter { context.painter() };
painter.fill_ellipse(control_box_rect.to_type<int>(), control_box_color); painter.fill_ellipse(control_box_rect.to_type<int>(), control_box_color);
context.painter().draw_triangle(playback_button_location.to_type<int>(), play_button_coordinates, playback_button_color); fill_triangle(context.painter(), playback_button_location.to_type<int>(), play_button_coordinates, playback_button_color);
} }
VideoPaintable::DispatchEventOfSameName VideoPaintable::handle_mouseup(Badge<EventHandler>, CSSPixelPoint position, unsigned button, unsigned) VideoPaintable::DispatchEventOfSameName VideoPaintable::handle_mouseup(Badge<EventHandler>, CSSPixelPoint position, unsigned button, unsigned)