RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:47:46 +00:00
Code Issues Activity Actions

LibChess: Return Commands by pointer from FooCommand::from_string()

Browse source 
This removes this slightly silly pattern:
`make<FooCommand>(FooCommand::from_string(s))`

Also, let's propagate OOM here, even if nobody reacts to it yet.
This commit is contained in:
Sam Atkins 2023-04-21 14:51:39 +01:00 • committed by Andreas Kling
parent b904435866
commit 6576bbc098
3 changed files with 76 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Userland/Libraries/LibChess/UCICommand.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020-2022, the SerenityOS developers.
* Copyright (c) 2023, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -38,15 +39,15 @@ public:
Info,
Option,
};
virtual DeprecatedString to_deprecated_string() const = 0;
virtual ~Command() = default;
protected:
explicit Command(Type type)
: Core::Event(to_underlying(type))
{
}
virtual DeprecatedString to_deprecated_string() const = 0;
virtual ~Command() = default;
};
class UCICommand : public Command {
@ -56,7 +57,7 @@ public:
{
}
static UCICommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<UCICommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
};
@ -74,7 +75,7 @@ public:
{
}
static DebugCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<DebugCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -91,7 +92,7 @@ public:
{
}
static IsReadyCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<IsReadyCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
};
@ -105,7 +106,7 @@ public:
{
}
static SetOptionCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<SetOptionCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -126,7 +127,7 @@ public:
{
}
static PositionCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<PositionCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -145,7 +146,7 @@ public:
{
}
static GoCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<GoCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -170,7 +171,7 @@ public:
{
}
static StopCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<StopCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
};
@ -189,7 +190,7 @@ public:
{
}
static IdCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<IdCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -208,7 +209,7 @@ public:
{
}
static UCIOkCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<UCIOkCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
};
@ -220,7 +221,7 @@ public:
{
}
static ReadyOkCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<ReadyOkCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
};
@ -233,7 +234,7 @@ public:
{
}
static BestMoveCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<BestMoveCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -250,7 +251,7 @@ public:
{
}
static InfoCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<InfoCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
@ -275,7 +276,7 @@ public:
{
}
static QuitCommand from_string(StringView command);
static ErrorOr<NonnullOwnPtr<QuitCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override;
};