RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:07:45 +00:00
Code Issues Activity Actions

LibChess: Return Commands by pointer from FooCommand::from_string()

Browse source 
This removes this slightly silly pattern:
`make<FooCommand>(FooCommand::from_string(s))`

Also, let's propagate OOM here, even if nobody reacts to it yet.
This commit is contained in:
Sam Atkins 2023-04-21 14:51:39 +01:00 • committed by Andreas Kling
parent b904435866
commit 6576bbc098
3 changed files with 76 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/Libraries/LibChess/UCIEndpoint.cpp
View file

@ -89,31 +89,31 @@ NonnullOwnPtr<Command> Endpoint::read_command()
dbgln_if(UCI_DEBUG, "{} Received UCI Command: {}", class_name(), line);
if (line == "uci") {
return make<UCICommand>(UCICommand::from_string(line));
return UCICommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("debug"sv)) {
return make<DebugCommand>(DebugCommand::from_string(line));
return DebugCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("isready"sv)) {
return make<IsReadyCommand>(IsReadyCommand::from_string(line));
return IsReadyCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("setoption"sv)) {
return make<SetOptionCommand>(SetOptionCommand::from_string(line));
return SetOptionCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("position"sv)) {
return make<PositionCommand>(PositionCommand::from_string(line));
return PositionCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("go"sv)) {
return make<GoCommand>(GoCommand::from_string(line));
return GoCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("stop"sv)) {
return make<StopCommand>(StopCommand::from_string(line));
return StopCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("id"sv)) {
return make<IdCommand>(IdCommand::from_string(line));
return IdCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("uciok"sv)) {
return make<UCIOkCommand>(UCIOkCommand::from_string(line));
return UCIOkCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("readyok"sv)) {
return make<ReadyOkCommand>(ReadyOkCommand::from_string(line));
return ReadyOkCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("bestmove"sv)) {
return make<BestMoveCommand>(BestMoveCommand::from_string(line));
return BestMoveCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("info"sv)) {
return make<InfoCommand>(InfoCommand::from_string(line));
return InfoCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
} else if (line.starts_with("quit"sv)) {
return make<QuitCommand>(QuitCommand::from_string(line));
return QuitCommand::from_string(line).release_value_but_fixme_should_propagate_errors();
}
dbgln("command line: {}", line);