RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:27:34 +00:00
Code Issues Activity Actions

LibC+LibPthread: Use FUTEX_PRIVATE_FLAG in more places

Browse source 
Performance go brrrrr
This commit is contained in:
Sergey Bugaev 2021-07-06 20:03:49 +03:00 • committed by Andreas Kling
parent 39a3f42534
commit 65b0642dd0
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibC/serenity.h
View file

@ -82,14 +82,14 @@ static ALWAYS_INLINE int futex_wait(uint32_t* userspace_address, uint32_t value,
if (clockid == CLOCK_REALTIME || clockid == CLOCK_REALTIME_COARSE) if (clockid == CLOCK_REALTIME || clockid == CLOCK_REALTIME_COARSE)
op |= FUTEX_CLOCK_REALTIME; op |= FUTEX_CLOCK_REALTIME;
} else { } else {
op = FUTEX_WAIT; op = FUTEX_WAIT | FUTEX_PRIVATE_FLAG;
} }
return futex(userspace_address, op, value, abstime, nullptr, FUTEX_BITSET_MATCH_ANY); return futex(userspace_address, op, value, abstime, nullptr, FUTEX_BITSET_MATCH_ANY);
} }
static ALWAYS_INLINE int futex_wake(uint32_t* userspace_address, uint32_t count) static ALWAYS_INLINE int futex_wake(uint32_t* userspace_address, uint32_t count)
{ {
return futex(userspace_address, FUTEX_WAKE, count, NULL, NULL, 0); return futex(userspace_address, FUTEX_WAKE | FUTEX_PRIVATE_FLAG, count, NULL, NULL, 0);
} }
#define PURGE_ALL_VOLATILE 0x1 #define PURGE_ALL_VOLATILE 0x1

2
Userland/Libraries/LibPthread/pthread_cond.cpp
View file

@ -127,7 +127,7 @@ int pthread_cond_broadcast(pthread_cond_t* cond)
pthread_mutex_t* mutex = AK::atomic_load(&cond->mutex, AK::memory_order_relaxed); pthread_mutex_t* mutex = AK::atomic_load(&cond->mutex, AK::memory_order_relaxed);
VERIFY(mutex); VERIFY(mutex);
int rc = futex(&cond->value, FUTEX_REQUEUE, 1, nullptr, &mutex->lock, INT_MAX); int rc = futex(&cond->value, FUTEX_REQUEUE | FUTEX_PRIVATE_FLAG, 1, nullptr, &mutex->lock, INT_MAX);
VERIFY(rc >= 0); VERIFY(rc >= 0);
return 0; return 0;
} }

4
Userland/Libraries/LibPthread/pthread_once.cpp
View file

@ -45,7 +45,7 @@ int pthread_once(pthread_once_t* self, void (*callback)(void))
// anyone. // anyone.
break; break;
case State::PERFORMING_WITH_WAITERS: case State::PERFORMING_WITH_WAITERS:
futex(self, FUTEX_WAKE, INT_MAX, nullptr, nullptr, 0); futex_wake(self, INT_MAX);
break; break;
} }
@ -75,7 +75,7 @@ int pthread_once(pthread_once_t* self, void (*callback)(void))
[[fallthrough]]; [[fallthrough]];
case State::PERFORMING_WITH_WAITERS: case State::PERFORMING_WITH_WAITERS:
// Let's wait for it. // Let's wait for it.
futex(self, FUTEX_WAIT, state2, nullptr, nullptr, 0); futex_wait(self, state2, nullptr, 0);
// We have been woken up, but that might have been due to a signal // We have been woken up, but that might have been due to a signal
// or something, so we have to reevaluate. We need acquire ordering // or something, so we have to reevaluate. We need acquire ordering
// here for the same reason as above. Hopefully we'll just see // here for the same reason as above. Hopefully we'll just see