RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:47:35 +00:00
Code Issues Activity Actions

LibGfx: Make ScaledFont::glyph_height() return the pixel height

Browse source 
This was returning the point height which didn't match BitmapFont and
led to bogus line heights in GUI::TextEditor.
This commit is contained in:
Andreas Kling 2023-01-05 18:51:34 +01:00
parent cddcf531b1
commit 65c8cd37e3
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/Font/ScaledFont.h
View file

@ -55,7 +55,7 @@ public:
virtual float glyph_or_emoji_width(u32 code_point) const override;
virtual float glyphs_horizontal_kerning(u32 left_code_point, u32 right_code_point) const override;
virtual float preferred_line_height() const override { return metrics().height() + metrics().line_gap; }
virtual u8 glyph_height() const override { return m_point_height; }
virtual u8 glyph_height() const override { return pixel_size(); }
virtual int x_height() const override { return m_point_height; } // FIXME: Read from font
virtual u8 min_glyph_width() const override { return 1; } // FIXME: Read from font
virtual u8 max_glyph_width() const override { return m_point_width; } // FIXME: Read from font