RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:07:34 +00:00
Code Issues Activity Actions

Kernel: Resolve clang-tidy readability-make-member-function-const

Browse source 
... In files included from Kernel/Thread.cpp or Kernel/Process.cpp

Some places the warning is suppressed, because we do not want a const
object do have non-const access to the returned sub-object.
This commit is contained in:
Andrew Kaster 2021-10-31 15:54:39 -06:00 • committed by Andreas Kling
parent a92132e44a
commit 65edc62c02
11 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/FileSystem.h
View file

@ -78,7 +78,7 @@ private:
bool m_readonly { false };
};
inline FileSystem* InodeIdentifier::fs()
inline FileSystem* InodeIdentifier::fs() // NOLINT(readability-make-member-function-const) const InodeIdentifiers should not be able to modify the FileSystem
{
return FileSystem::from_fsid(m_fsid);
}

2
Kernel/FileSystem/SysFS.h
View file

@ -34,7 +34,7 @@ class SysFSDeviceComponent final
public:
static NonnullRefPtr<SysFSDeviceComponent> must_create(Device const&);
bool is_block_device() { return m_block_device; }
bool is_block_device() const { return m_block_device; }
private:
explicit SysFSDeviceComponent(Device const&);