RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

Kernel+LibC+UserspaceEmulator: Bring back sys$dup2()

Browse source 
This is racy in userspace and non-racy in kernelspace so let's keep
it in kernelspace.

The behavior change where CLOEXEC is preserved when dup2() is called
with (old_fd == new_fd) was good though, let's keep that.
This commit is contained in:
Andreas Kling 2020-08-15 10:54:00 +02:00
parent bf247fb45f
commit 65f2270232
7 changed files with 59 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
DevTools/UserspaceEmulator/Emulator.cpp
View file

@ -253,6 +253,8 @@ u32 Emulator::virt_syscall(u32 function, u32 arg1, u32 arg2, u32 arg3)
switch (function) {
case SC_chdir:
return virt$chdir(arg1, arg2);
case SC_dup2:
return virt$dup2(arg1, arg2);
case SC_access:
return virt$access(arg1, arg2, arg3);
case SC_waitid:
@ -1348,4 +1350,9 @@ int Emulator::virt$chdir(FlatPtr path, size_t path_length)
return syscall(SC_chdir, host_path.data(), host_path.size());
}
int Emulator::virt$dup2(int old_fd, int new_fd)
{
return syscall(SC_dup2, old_fd, new_fd);
}
}

1
DevTools/UserspaceEmulator/Emulator.h
View file

@ -138,6 +138,7 @@ private:
ssize_t virt$getrandom(FlatPtr buffer, size_t buffer_size, unsigned int flags);
int virt$sleep(unsigned);
int virt$chdir(FlatPtr, size_t);
int virt$dup2(int, int);
int virt$getpgrp();
int virt$getpgid(pid_t);
int virt$setpgid(pid_t pid, pid_t pgid);