RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

LibRegex: Account for eof after \<x> when 'x' leads to legacy behaviour

Browse source
This commit is contained in:
Ali Mohammad Pur 2022-09-06 23:55:09 +04:30 • committed by Ali Mohammad Pur
parent 48442059fc
commit 660d2b53b1
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibRegex/Regex.cpp
View file

@ -603,6 +603,7 @@ TEST_CASE(ECMA262_parse)
{ "(?<𝓑𝓻𝓸𝔀𝓷>a)"sv }, { "(?<𝓑𝓻𝓸𝔀𝓷>a)"sv },
{ "((?=lg)?[vl]k\\-?\\d{3}) bui| 3\\.[-\\w; ]{10}lg?-([06cv9]{3,4})"sv, regex::Error::NoError, ECMAScriptFlags::BrowserExtended }, // #12373, quantifiable assertions. { "((?=lg)?[vl]k\\-?\\d{3}) bui| 3\\.[-\\w; ]{10}lg?-([06cv9]{3,4})"sv, regex::Error::NoError, ECMAScriptFlags::BrowserExtended }, // #12373, quantifiable assertions.
{ parse_test_case_long_disjunction_chain.view() }, // A whole lot of disjunctions, should not overflow the stack. { parse_test_case_long_disjunction_chain.view() }, // A whole lot of disjunctions, should not overflow the stack.
{ "(\"|')(?:(?!\\2)[^\\\\\\r\\n]|\\\\.)*\\2"sv, regex::Error::NoError, ECMAScriptFlags::BrowserExtended }, // LegacyOctalEscapeSequence should not consume too many chars (and should not crash)
}; };
for (auto& test : tests) { for (auto& test : tests) {

2
Userland/Libraries/LibRegex/RegexParser.cpp
View file

@ -1582,7 +1582,7 @@ bool ECMA262Parser::parse_atom_escape(ByteCode& stack, size_t& match_length_mini
} }
// If not, put the characters back. // If not, put the characters back.
back(escape_str.length()); back(escape_str.length() + (done() ? 0 : 1));
} }
Vector<CompareTypeAndValuePair> escape_compares; Vector<CompareTypeAndValuePair> escape_compares;