1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00

LibGfx: Change class_name to use StringView instead of char const*

This helps make the overall codebase consistent. `class_name()` in
`Kernel` is always `StringView`, but not elsewhere.

Additionally, this results in the `strlen` (which needs to be done
when printing or other operations) always being computed at
compile-time.
This commit is contained in:
Lenny Maiorani 2022-03-16 17:55:56 -06:00 committed by Linus Groh
parent aa9d6f17b6
commit 66189169f9
10 changed files with 20 additions and 10 deletions

View file

@ -7,6 +7,7 @@
#pragma once
#include "GenericConvolutionFilter.h"
#include <AK/StringView.h>
namespace Gfx {
@ -16,7 +17,7 @@ public:
BoxBlurFilter() = default;
virtual ~BoxBlurFilter() = default;
virtual const char* class_name() const override { return "BoxBlurFilter"; }
virtual StringView class_name() const override { return "BoxBlurFilter"sv; }
};
}

View file

@ -8,6 +8,7 @@
#include "ColorFilter.h"
#include <AK/NonnullOwnPtr.h>
#include <AK/StringView.h>
namespace Gfx {
class ColorBlindnessFilter : public ColorFilter {
@ -35,7 +36,7 @@ public:
}
virtual ~ColorBlindnessFilter() = default;
virtual char const* class_name() const override { return "ColorBlindnessFilter"; }
virtual StringView class_name() const override { return "ColorBlindnessFilter"sv; }
static NonnullOwnPtr<ColorBlindnessFilter> create_protanopia();
static NonnullOwnPtr<ColorBlindnessFilter> create_protanomaly();

View file

@ -6,6 +6,7 @@
#pragma once
#include <AK/StringView.h>
#include <LibGfx/Bitmap.h>
#include <LibGfx/Rect.h>
@ -21,7 +22,7 @@ public:
};
virtual ~Filter() = default;
virtual const char* class_name() const = 0;
virtual StringView class_name() const = 0;
virtual void apply(Bitmap&, IntRect const&, Bitmap const&, IntRect const&, Parameters const&) {};
virtual void apply(Bitmap&, IntRect const&, Bitmap const&, IntRect const&) {};

View file

@ -7,6 +7,7 @@
#pragma once
#include "Filter.h"
#include <AK/StringView.h>
#include <LibGfx/Matrix.h>
#include <LibGfx/Matrix4x4.h>
@ -61,7 +62,7 @@ public:
GenericConvolutionFilter() = default;
virtual ~GenericConvolutionFilter() = default;
virtual const char* class_name() const override { return "GenericConvolutionFilter"; }
virtual StringView class_name() const override { return "GenericConvolutionFilter"sv; }
virtual void apply(Bitmap& target_bitmap, const IntRect& target_rect, const Bitmap& source_bitmap, const IntRect& source_rect, const Filter::Parameters& parameters) override
{

View file

@ -6,6 +6,7 @@
#pragma once
#include <AK/StringView.h>
#include <LibGfx/Filters/ColorFilter.h>
namespace Gfx {
@ -15,7 +16,7 @@ public:
GrayscaleFilter() = default;
virtual ~GrayscaleFilter() = default;
virtual char const* class_name() const override { return "GrayscaleFilter"; }
virtual StringView class_name() const override { return "GrayscaleFilter"sv; }
protected:
Color convert_color(Color original) override { return original.to_grayscale(); };

View file

@ -6,6 +6,7 @@
#pragma once
#include <AK/StringView.h>
#include <LibGfx/Filters/ColorFilter.h>
namespace Gfx {
@ -15,7 +16,7 @@ public:
InvertFilter() = default;
virtual ~InvertFilter() = default;
virtual char const* class_name() const override { return "InvertFilter"; }
virtual StringView class_name() const override { return "InvertFilter"sv; }
protected:
Color convert_color(Color original) override { return original.inverted(); };

View file

@ -7,6 +7,7 @@
#pragma once
#include "GenericConvolutionFilter.h"
#include <AK/StringView.h>
namespace Gfx {
@ -15,7 +16,7 @@ public:
LaplacianFilter() = default;
virtual ~LaplacianFilter() = default;
virtual const char* class_name() const override { return "LaplacianFilter"; }
virtual StringView class_name() const override { return "LaplacianFilter"sv; }
};
}

View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/StdLibExtras.h>
#include <AK/StringView.h>
#include <LibGfx/Filters/ColorFilter.h>
#include <math.h>
@ -20,7 +21,7 @@ public:
}
virtual ~SepiaFilter() = default;
virtual char const* class_name() const override { return "SepiaFilter"; }
virtual StringView class_name() const override { return "SepiaFilter"sv; }
protected:
Color convert_color(Color original) override { return original.sepia(m_amount); };

View file

@ -7,6 +7,7 @@
#pragma once
#include "GenericConvolutionFilter.h"
#include <AK/StringView.h>
namespace Gfx {
@ -15,7 +16,7 @@ public:
SharpenFilter() = default;
virtual ~SharpenFilter() = default;
virtual const char* class_name() const override { return "SharpenFilter"; }
virtual StringView class_name() const override { return "SharpenFilter"sv; }
};
}

View file

@ -8,6 +8,7 @@
#include "GenericConvolutionFilter.h"
#include <AK/StdLibExtras.h>
#include <AK/StringView.h>
namespace Gfx {
@ -17,6 +18,6 @@ public:
SpatialGaussianBlurFilter() = default;
virtual ~SpatialGaussianBlurFilter() = default;
virtual const char* class_name() const override { return "SpatialGaussianBlurFilter"; }
virtual StringView class_name() const override { return "SpatialGaussianBlurFilter"sv; }
};
}