From 6625edb5d206e62c945c78d507772476259811b3 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 17 Mar 2022 15:28:56 +0100 Subject: [PATCH] Kernel: When receiving unexpected TCP flags, print the flags It'll be easier to understand what might be happening if we know which unexpected flags are actually showing up. :^) --- Kernel/Net/NetworkTask.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/Net/NetworkTask.cpp b/Kernel/Net/NetworkTask.cpp index 29e8c74e62..b499e3fb39 100644 --- a/Kernel/Net/NetworkTask.cpp +++ b/Kernel/Net/NetworkTask.cpp @@ -435,11 +435,11 @@ void handle_tcp(IPv4Packet const& ipv4_packet, Time const& packet_timestamp) switch (socket->state()) { case TCPSocket::State::Closed: - dbgln("handle_tcp: unexpected flags in Closed state"); + dbgln("handle_tcp: unexpected flags in Closed state ({:x})", tcp_packet.flags()); // TODO: we may want to send an RST here, maybe as a configurable option return; case TCPSocket::State::TimeWait: - dbgln("handle_tcp: unexpected flags in TimeWait state"); + dbgln("handle_tcp: unexpected flags in TimeWait state ({:x})", tcp_packet.flags()); (void)socket->send_tcp_packet(TCPFlags::RST); socket->set_state(TCPSocket::State::Closed); return;