RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:07:35 +00:00
Code Issues Activity Actions

Kernel: Use u64 instead of size_t for File::can_write offset

Browse source 
This ensures offsets will not be truncated on large files on i686.
This commit is contained in:
Idan Horowitz 2022-01-25 20:19:35 +02:00
parent 9ce537d703
commit 664ca58746
40 changed files with 40 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Devices/Audio/AC97.h
View file

@ -32,7 +32,7 @@ public:
// ^CharacterDevice
virtual bool can_read(const OpenFileDescription&, u64) const override { return false; }
virtual bool can_write(const OpenFileDescription&, size_t) const override { return true; }
virtual bool can_write(const OpenFileDescription&, u64) const override { return true; }
virtual ErrorOr<void> ioctl(OpenFileDescription&, unsigned, Userspace<void*>) override;
virtual ErrorOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override;

2
Kernel/Devices/Audio/SB16.h
View file

@ -29,7 +29,7 @@ public:
virtual bool can_read(const OpenFileDescription&, u64) const override;
virtual ErrorOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override;
virtual bool can_write(const OpenFileDescription&, size_t) const override { return true; }
virtual bool can_write(const OpenFileDescription&, u64) const override { return true; }
virtual StringView purpose() const override { return class_name(); }