RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:27:39 +00:00
Code Issues Activity Actions

Kernel: Use u64 instead of size_t for File::can_write offset

Browse source 
This ensures offsets will not be truncated on large files on i686.
This commit is contained in:
Idan Horowitz 2022-01-25 20:19:35 +02:00
parent 9ce537d703
commit 664ca58746
40 changed files with 40 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Net/IPv4Socket.cpp
View file

@ -170,7 +170,7 @@ bool IPv4Socket::can_read(const OpenFileDescription&, u64) const
return m_can_read;
}
bool IPv4Socket::can_write(const OpenFileDescription&, size_t) const
bool IPv4Socket::can_write(const OpenFileDescription&, u64) const
{
return true;
}

2
Kernel/Net/IPv4Socket.h
View file

@ -38,7 +38,7 @@ public:
virtual void get_local_address(sockaddr*, socklen_t*) override;
virtual void get_peer_address(sockaddr*, socklen_t*) override;
virtual bool can_read(const OpenFileDescription&, u64) const override;
virtual bool can_write(const OpenFileDescription&, size_t) const override;
virtual bool can_write(const OpenFileDescription&, u64) const override;
virtual ErrorOr<size_t> sendto(OpenFileDescription&, const UserOrKernelBuffer&, size_t, int, Userspace<const sockaddr*>, socklen_t) override;
virtual ErrorOr<size_t> recvfrom(OpenFileDescription&, UserOrKernelBuffer&, size_t, int flags, Userspace<sockaddr*>, Userspace<socklen_t*>, Time&) override;
virtual ErrorOr<void> setsockopt(int level, int option, Userspace<const void*>, socklen_t) override;

2
Kernel/Net/LocalSocket.cpp
View file

@ -280,7 +280,7 @@ bool LocalSocket::has_attached_peer(const OpenFileDescription& description) cons
return false;
}
bool LocalSocket::can_write(const OpenFileDescription& description, size_t) const
bool LocalSocket::can_write(const OpenFileDescription& description, u64) const
{
auto role = this->role(description);
if (role == Role::Accepted)

2
Kernel/Net/LocalSocket.h
View file

@ -43,7 +43,7 @@ public:
virtual ErrorOr<void> attach(OpenFileDescription&) override;
virtual void detach(OpenFileDescription&) override;
virtual bool can_read(const OpenFileDescription&, u64) const override;
virtual bool can_write(const OpenFileDescription&, size_t) const override;
virtual bool can_write(const OpenFileDescription&, u64) const override;
virtual ErrorOr<size_t> sendto(OpenFileDescription&, const UserOrKernelBuffer&, size_t, int, Userspace<const sockaddr*>, socklen_t) override;
virtual ErrorOr<size_t> recvfrom(OpenFileDescription&, UserOrKernelBuffer&, size_t, int flags, Userspace<sockaddr*>, Userspace<socklen_t*>, Time&) override;
virtual ErrorOr<void> getsockopt(OpenFileDescription&, int level, int option, Userspace<void*>, Userspace<socklen_t*>) override;

2
Kernel/Net/TCPSocket.cpp
View file

@ -614,7 +614,7 @@ void TCPSocket::retransmit_packets()
});
}
bool TCPSocket::can_write(const OpenFileDescription& file_description, size_t size) const
bool TCPSocket::can_write(const OpenFileDescription& file_description, u64 size) const
{
if (!IPv4Socket::can_write(file_description, size))
return false;

2
Kernel/Net/TCPSocket.h
View file

@ -159,7 +159,7 @@ public:
virtual ErrorOr<void> close() override;
virtual bool can_write(const OpenFileDescription&, size_t) const override;
virtual bool can_write(const OpenFileDescription&, u64) const override;
static NetworkOrdered<u16> compute_tcp_checksum(IPv4Address const& source, IPv4Address const& destination, TCPPacket const&, u16 payload_size);