RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Mark NonnullGCPtr::ptr() as returns_nonnull

Browse source 
This invariant is enforced by the fact that `NonnullGCPtr` can only be
constructed from references.

This commit fixes an instance where we compared a pointer to null after
we have already dereferenced it.
This commit is contained in:
Daniel Bertalan 2023-07-26 19:56:09 +02:00 • committed by Tim Flynn
parent 9feb1ce39f
commit 66645cdc94
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Heap/GCPtr.h
View file

@ -60,13 +60,13 @@ public:
return *this;
}
T* operator->() const { return m_ptr; }
RETURNS_NONNULL T* operator->() const { return m_ptr; }
T& operator*() const { return *m_ptr; }
T* ptr() const { return m_ptr; }
RETURNS_NONNULL T* ptr() const { return m_ptr; }
operator T*() const { return m_ptr; }
RETURNS_NONNULL operator T*() const { return m_ptr; }
operator T&() const { return *m_ptr; }

2
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -682,7 +682,7 @@ constexpr bool should_ignore_keydown_event(u32 code_point)
bool EventHandler::fire_keyboard_event(FlyString const& event_name, HTML::BrowsingContext& browsing_context, KeyCode key, unsigned int modifiers, u32 code_point)
{
JS::NonnullGCPtr<DOM::Document> document = *browsing_context.active_document();
JS::GCPtr<DOM::Document> document = browsing_context.active_document();
if (!document)
return false;