RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:47:35 +00:00
Code Issues Activity Actions

Kernel: Correct Spurious Interrupt handlers' controller model() method

Browse source 
We don't return blindly the IRQ controller's model(), if the Spurious
IRQ handler is installed in IOAPIC environment, it's misleading to
return "IOAPIC" string since IOAPIC doesn't really handle Spurious
IRQs, therefore we return a "" string.
This commit is contained in:
Liav A 2020-03-08 02:35:57 +02:00 • committed by Andreas Kling
parent 4cc96a7aa9
commit 666990fbcb
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Interrupts/SpuriousInterruptHandler.cpp
View file

@ -81,4 +81,10 @@ void SpuriousInterruptHandler::disable_interrupt_vector()
m_responsible_irq_controller->disable(interrupt_number());
}
const char* SpuriousInterruptHandler::controller() const
{
if (m_responsible_irq_controller->type() == IRQControllerType::i82093AA)
return "";
return m_responsible_irq_controller->model();
}
}

2
Kernel/Interrupts/SpuriousInterruptHandler.h
View file

@ -52,7 +52,7 @@ public:
virtual HandlerType type() const override { return HandlerType::SpuriousInterruptHandler; }
virtual const char* purpose() const override { return "Spurious Interrupt Handler"; }
virtual const char* controller() const override { return m_responsible_irq_controller->model(); }
virtual const char* controller() const override;
private:
void enable_interrupt_vector();