RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:37:35 +00:00
Code Issues Activity Actions

LibJS: Add the Function.[[ThisMode]] field

Browse source 
This is not a behavioral change in itself, just prep work for future
spec-compliance changes.
This commit is contained in:
Andreas Kling 2021-06-25 20:53:17 +02:00
parent b650d11dd3
commit 667bba2410
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibJS/Runtime/Function.h
View file

@ -47,6 +47,16 @@ public:
// Used as the outer environment when evaluating the code of the function. // Used as the outer environment when evaluating the code of the function.
virtual EnvironmentRecord* environment() { return nullptr; } virtual EnvironmentRecord* environment() { return nullptr; }
enum class ThisMode : u8 {
Lexical,
Strict,
Global,
};
// [[ThisMode]]
ThisMode this_mode() const { return m_this_mode; }
void set_this_mode(ThisMode this_mode) { m_this_mode = this_mode; }
protected: protected:
virtual void visit_edges(Visitor&) override; virtual void visit_edges(Visitor&) override;
@ -59,6 +69,7 @@ private:
Vector<Value> m_bound_arguments; Vector<Value> m_bound_arguments;
Value m_home_object; Value m_home_object;
ConstructorKind m_constructor_kind = ConstructorKind::Base; ConstructorKind m_constructor_kind = ConstructorKind::Base;
ThisMode m_this_mode { ThisMode::Global };
}; };
} }

7
Userland/Libraries/LibJS/Runtime/ScriptFunction.cpp
View file

@ -61,6 +61,13 @@ ScriptFunction::ScriptFunction(GlobalObject& global_object, const FlyString& nam
, m_is_strict(is_strict) , m_is_strict(is_strict)
, m_is_arrow_function(is_arrow_function) , m_is_arrow_function(is_arrow_function)
{ {
// NOTE: This logic is from OrdinaryFunctionCreate, https://tc39.es/ecma262/#sec-ordinaryfunctioncreate
if (m_is_arrow_function)
set_this_mode(ThisMode::Lexical);
else if (m_is_strict)
set_this_mode(ThisMode::Strict);
else
set_this_mode(ThisMode::Global);
} }
void ScriptFunction::initialize(GlobalObject& global_object) void ScriptFunction::initialize(GlobalObject& global_object)