RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:17:36 +00:00
Code Issues Activity Actions

LibJS/Bytecode: Fix non-string keys not being excluded in rest object

Browse source 
By converting the excluded names to PropertyKey before filtering, we
ensure that non-string keys get excluded as needed.

14 new passes on test262. :^)
This commit is contained in:
Andreas Kling 2023-06-25 16:39:30 +02:00
parent 6f0952c358
commit 66936a0d61
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -359,15 +359,16 @@ ThrowCompletionOr<void> CopyObjectExcludingProperties::execute_impl(Bytecode::In
auto to_object = Object::create(realm, realm.intrinsics().object_prototype()); auto to_object = Object::create(realm, realm.intrinsics().object_prototype());
HashTable<Value, ValueTraits> excluded_names; HashTable<PropertyKey> excluded_names;
for (size_t i = 0; i < m_excluded_names_count; ++i) for (size_t i = 0; i < m_excluded_names_count; ++i) {
excluded_names.set(interpreter.reg(m_excluded_names[i])); excluded_names.set(TRY(interpreter.reg(m_excluded_names[i]).to_property_key(vm)));
}
auto own_keys = TRY(from_object->internal_own_property_keys()); auto own_keys = TRY(from_object->internal_own_property_keys());
for (auto& key : own_keys) { for (auto& key : own_keys) {
if (!excluded_names.contains(key)) { auto property_key = TRY(key.to_property_key(vm));
auto property_key = TRY(key.to_property_key(vm)); if (!excluded_names.contains(property_key)) {
auto property_value = TRY(from_object->get(property_key)); auto property_value = TRY(from_object->get(property_key));
to_object->define_direct_property(property_key, property_value, JS::default_attributes); to_object->define_direct_property(property_key, property_value, JS::default_attributes);
} }