From 66c41e7c45e8c2101c48cfdac3aaed4935fe70cc Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 4 May 2023 16:44:31 +0200 Subject: [PATCH] LibWeb: Use JS::SafeFunction for module fetching callbacks This fixes another GC crash seen on https://shopify.com/ Found it by collecting garbage after every 500th heap allocation. --- Userland/Libraries/LibWeb/HTML/Scripting/Fetching.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.h b/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.h index 48345a15b5..3bbac8402e 100644 --- a/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.h +++ b/Userland/Libraries/LibWeb/HTML/Scripting/Fetching.h @@ -12,7 +12,7 @@ namespace Web::HTML { -using ModuleCallback = Function; +using ModuleCallback = JS::SafeFunction; class DescendantFetchingContext : public RefCounted { public: