RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

Kernel: Add FIXME about allocation waste in kmalloc slabheap

Browse source
This commit is contained in:
Andreas Kling 2021-12-26 18:47:20 +01:00
parent 43099fb387
commit 66d35f2936
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Heap/kmalloc.cpp
View file

@ -105,6 +105,8 @@ public:
void* allocate() void* allocate()
{ {
if (m_usable_blocks.is_empty()) { if (m_usable_blocks.is_empty()) {
// FIXME: This allocation wastes `block_size` bytes due to the implementation of kmalloc_aligned().
// Handle this with a custom VM+page allocator instead of using kmalloc_aligned().
auto* slot = kmalloc_aligned(KmallocSlabBlock::block_size, KmallocSlabBlock::block_size); auto* slot = kmalloc_aligned(KmallocSlabBlock::block_size, KmallocSlabBlock::block_size);
if (!slot) { if (!slot) {
// FIXME: Dare to return nullptr! // FIXME: Dare to return nullptr!