RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:37:45 +00:00
Code Issues Activity Actions

AK: Move RefCountedBase definitions out-of-line

Browse source 
This dramatically reduces code size since we no longer inline all these
VERIFY() checks everywhere. Appears to be performance neutral.
This commit is contained in:
Andreas Kling 2021-05-29 16:04:58 +02:00
parent d44e2c9ad9
commit 66f3ec687b
3 changed files with 53 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

38
AK/RefCounted.h
View file

@ -47,43 +47,15 @@ public:
using RefCountType = unsigned int;
using AllowOwnPtr = FalseType;
ALWAYS_INLINE void ref() const
{
auto old_ref_count = m_ref_count.fetch_add(1, AK::MemoryOrder::memory_order_relaxed);
VERIFY(old_ref_count > 0);
VERIFY(!Checked<RefCountType>::addition_would_overflow(old_ref_count, 1));
}
[[nodiscard]] ALWAYS_INLINE bool try_ref() const
{
RefCountType expected = m_ref_count.load(AK::MemoryOrder::memory_order_relaxed);
for (;;) {
if (expected == 0)
return false;
VERIFY(!Checked<RefCountType>::addition_would_overflow(expected, 1));
if (m_ref_count.compare_exchange_strong(expected, expected + 1, AK::MemoryOrder::memory_order_acquire))
return true;
}
}
ALWAYS_INLINE RefCountType ref_count() const
{
return m_ref_count.load(AK::MemoryOrder::memory_order_relaxed);
}
void ref() const;
[[nodiscard]] bool try_ref() const;
[[nodiscard]] RefCountType ref_count() const;
protected:
RefCountedBase() = default;
ALWAYS_INLINE ~RefCountedBase()
{
VERIFY(m_ref_count.load(AK::MemoryOrder::memory_order_relaxed) == 0);
}
~RefCountedBase();
ALWAYS_INLINE RefCountType deref_base() const
{
auto old_ref_count = m_ref_count.fetch_sub(1, AK::MemoryOrder::memory_order_acq_rel);
VERIFY(old_ref_count > 0);
return old_ref_count - 1;
}
RefCountType deref_base() const;
mutable Atomic<RefCountType> m_ref_count { 1 };
};