RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

AK: Move RefCountedBase definitions out-of-line

Browse source 
This dramatically reduces code size since we no longer inline all these
VERIFY() checks everywhere. Appears to be performance neutral.
This commit is contained in:
Andreas Kling 2021-05-29 16:04:58 +02:00
parent d44e2c9ad9
commit 66f3ec687b
3 changed files with 53 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

47
AK/RefCounted.cpp Normal file
View file

@ -0,0 +1,47 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/RefCounted.h>
namespace AK {
RefCountedBase::~RefCountedBase()
{
VERIFY(m_ref_count.load(AK::MemoryOrder::memory_order_relaxed) == 0);
}
void RefCountedBase::ref() const
{
auto old_ref_count = m_ref_count.fetch_add(1, AK::MemoryOrder::memory_order_relaxed);
VERIFY(old_ref_count > 0);
VERIFY(!Checked<RefCountType>::addition_would_overflow(old_ref_count, 1));
}
[[nodiscard]] bool RefCountedBase::try_ref() const
{
RefCountType expected = m_ref_count.load(AK::MemoryOrder::memory_order_relaxed);
for (;;) {
if (expected == 0)
return false;
VERIFY(!Checked<RefCountType>::addition_would_overflow(expected, 1));
if (m_ref_count.compare_exchange_strong(expected, expected + 1, AK::MemoryOrder::memory_order_acquire))
return true;
}
}
RefCountedBase::RefCountType RefCountedBase::ref_count() const
{
return m_ref_count.load(AK::MemoryOrder::memory_order_relaxed);
}
RefCountedBase::RefCountType RefCountedBase::deref_base() const
{
auto old_ref_count = m_ref_count.fetch_sub(1, AK::MemoryOrder::memory_order_acq_rel);
VERIFY(old_ref_count > 0);
return old_ref_count - 1;
}
}

38
AK/RefCounted.h
View file

@ -47,43 +47,15 @@ public:
using RefCountType = unsigned int; using RefCountType = unsigned int;
using AllowOwnPtr = FalseType; using AllowOwnPtr = FalseType;
ALWAYS_INLINE void ref() const void ref() const;
{ [[nodiscard]] bool try_ref() const;
auto old_ref_count = m_ref_count.fetch_add(1, AK::MemoryOrder::memory_order_relaxed); [[nodiscard]] RefCountType ref_count() const;
VERIFY(old_ref_count > 0);
VERIFY(!Checked<RefCountType>::addition_would_overflow(old_ref_count, 1));
}
[[nodiscard]] ALWAYS_INLINE bool try_ref() const
{
RefCountType expected = m_ref_count.load(AK::MemoryOrder::memory_order_relaxed);
for (;;) {
if (expected == 0)
return false;
VERIFY(!Checked<RefCountType>::addition_would_overflow(expected, 1));
if (m_ref_count.compare_exchange_strong(expected, expected + 1, AK::MemoryOrder::memory_order_acquire))
return true;
}
}
ALWAYS_INLINE RefCountType ref_count() const
{
return m_ref_count.load(AK::MemoryOrder::memory_order_relaxed);
}
protected: protected:
RefCountedBase() = default; RefCountedBase() = default;
ALWAYS_INLINE ~RefCountedBase() ~RefCountedBase();
{
VERIFY(m_ref_count.load(AK::MemoryOrder::memory_order_relaxed) == 0);
}
ALWAYS_INLINE RefCountType deref_base() const RefCountType deref_base() const;
{
auto old_ref_count = m_ref_count.fetch_sub(1, AK::MemoryOrder::memory_order_acq_rel);
VERIFY(old_ref_count > 0);
return old_ref_count - 1;
}
mutable Atomic<RefCountType> m_ref_count { 1 }; mutable Atomic<RefCountType> m_ref_count { 1 };
}; };

1
Kernel/CMakeLists.txt
View file

@ -277,6 +277,7 @@ set(AK_SOURCES
../AK/JsonParser.cpp ../AK/JsonParser.cpp
../AK/JsonValue.cpp ../AK/JsonValue.cpp
../AK/LexicalPath.cpp ../AK/LexicalPath.cpp
../AK/RefCounted.cpp
../AK/String.cpp ../AK/String.cpp
../AK/StringBuilder.cpp ../AK/StringBuilder.cpp
../AK/StringImpl.cpp ../AK/StringImpl.cpp