From 66f98237a7365ca8e7f053e8c51a6ef1a7594ae7 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 25 Jan 2023 17:57:06 -0500 Subject: [PATCH] LibSQL: Don't interpret AK::Error codes as SQL error codes This makes error invocations such as Error::from_string_literal become associated with a SQLErrorCode (typically 0, AmbiguousColumnName). The result, when displayed to the user, is quite confusing, e.g.: Column name 'Heap()::write_block(): Oversized block' is ambiguous Instead, just interpret these as internal errors, so the error message is displayed as-is. --- Userland/Libraries/LibSQL/Result.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibSQL/Result.h b/Userland/Libraries/LibSQL/Result.h index e965ada00b..bf85ea6003 100644 --- a/Userland/Libraries/LibSQL/Result.h +++ b/Userland/Libraries/LibSQL/Result.h @@ -94,7 +94,7 @@ public: } ALWAYS_INLINE Result(Error error) - : m_error(static_cast(error.code())) + : m_error(SQLErrorCode::InternalError) , m_error_message(error.string_literal()) { }