mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 20:47:45 +00:00
AK: Replace the mutable String::replace API with an immutable version
This removes the awkward String::replace API which was the only String API which mutated the String and replaces it with a new immutable version that returns a new String with the replacements applied. This also fixes a couple of UAFs that were caused by the use of this API. As an optimization an equivalent StringView::replace API was also added to remove an unnecessary String allocations in the format of: `String { view }.replace(...);`
This commit is contained in:
parent
aba4c9579f
commit
6704961c82
26 changed files with 72 additions and 118 deletions
|
@ -27,10 +27,7 @@ static String make_input_acceptable_cpp(String const& input)
|
|||
return builder.to_string();
|
||||
}
|
||||
|
||||
String input_without_dashes = input;
|
||||
input_without_dashes.replace("-", "_");
|
||||
|
||||
return input_without_dashes;
|
||||
return input.replace("-", "_");
|
||||
}
|
||||
|
||||
static void report_parsing_error(StringView message, StringView filename, StringView input, size_t offset)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue