mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 15:07:45 +00:00
AK: Replace the mutable String::replace API with an immutable version
This removes the awkward String::replace API which was the only String API which mutated the String and replaces it with a new immutable version that returns a new String with the replacements applied. This also fixes a couple of UAFs that were caused by the use of this API. As an optimization an equivalent StringView::replace API was also added to remove an unnecessary String allocations in the format of: `String { view }.replace(...);`
This commit is contained in:
parent
aba4c9579f
commit
6704961c82
26 changed files with 72 additions and 118 deletions
|
@ -146,25 +146,21 @@ TEST_CASE(flystring)
|
|||
TEST_CASE(replace)
|
||||
{
|
||||
String test_string = "Well, hello Friends!";
|
||||
u32 replacements = test_string.replace("Friends", "Testers");
|
||||
EXPECT(replacements == 1);
|
||||
|
||||
test_string = test_string.replace("Friends", "Testers");
|
||||
EXPECT(test_string == "Well, hello Testers!");
|
||||
|
||||
replacements = test_string.replace("ell", "e're", true);
|
||||
EXPECT(replacements == 2);
|
||||
test_string = test_string.replace("ell", "e're", true);
|
||||
EXPECT(test_string == "We're, he'reo Testers!");
|
||||
|
||||
replacements = test_string.replace("!", " :^)");
|
||||
EXPECT(replacements == 1);
|
||||
test_string = test_string.replace("!", " :^)");
|
||||
EXPECT(test_string == "We're, he'reo Testers :^)");
|
||||
|
||||
test_string = String("111._.111._.111");
|
||||
replacements = test_string.replace("111", "|||", true);
|
||||
EXPECT(replacements == 3);
|
||||
test_string = test_string.replace("111", "|||", true);
|
||||
EXPECT(test_string == "|||._.|||._.|||");
|
||||
|
||||
replacements = test_string.replace("|||", "111");
|
||||
EXPECT(replacements == 1);
|
||||
test_string = test_string.replace("|||", "111");
|
||||
EXPECT(test_string == "111._.|||._.|||");
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue