mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 20:07:35 +00:00
AK: Replace the mutable String::replace API with an immutable version
This removes the awkward String::replace API which was the only String API which mutated the String and replaces it with a new immutable version that returns a new String with the replacements applied. This also fixes a couple of UAFs that were caused by the use of this API. As an optimization an equivalent StringView::replace API was also added to remove an unnecessary String allocations in the format of: `String { view }.replace(...);`
This commit is contained in:
parent
aba4c9579f
commit
6704961c82
26 changed files with 72 additions and 118 deletions
|
@ -130,9 +130,8 @@ GoToOffsetDialog::GoToOffsetDialog()
|
|||
m_text_editor->on_change = [this]() {
|
||||
auto text = m_text_editor->text();
|
||||
if (text.starts_with("0x")) {
|
||||
text.replace("0x", "");
|
||||
m_offset_type_box->set_selected_index(1);
|
||||
m_text_editor->set_text(text);
|
||||
m_text_editor->set_text(text.replace("0x", ""));
|
||||
}
|
||||
update_statusbar();
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue