mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 22:27:35 +00:00
AK: Replace the mutable String::replace API with an immutable version
This removes the awkward String::replace API which was the only String API which mutated the String and replaces it with a new immutable version that returns a new String with the replacements applied. This also fixes a couple of UAFs that were caused by the use of this API. As an optimization an equivalent StringView::replace API was also added to remove an unnecessary String allocations in the format of: `String { view }.replace(...);`
This commit is contained in:
parent
aba4c9579f
commit
6704961c82
26 changed files with 72 additions and 118 deletions
|
@ -1260,8 +1260,7 @@ void Window::set_modified(bool modified)
|
|||
|
||||
String Window::computed_title() const
|
||||
{
|
||||
String title = m_title;
|
||||
title.replace("[*]", is_modified() ? " (*)" : "");
|
||||
String title = m_title.replace("[*]", is_modified() ? " (*)" : "");
|
||||
if (client() && client()->is_unresponsive())
|
||||
return String::formatted("{} (Not responding)", title);
|
||||
return title;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue