LibELF: Warn on self-dlopening libraries while initializing

Userland/Libraries/LibELF/DynamicLinker.cpp

@@ -299,8 +299,16 @@ static void for_each_unfinished_dependency_of(String const& name, HashTable<Stri
     if (!loader.has_value())
         return;
 
-    if (loader.value()->is_fully_initialized())
+    if (loader.value()->is_fully_relocated()) {
+        if (!loader.value()->is_fully_initialized()) {
+            // If we are ending up here, that possibly means that this library either dlopens itself or a library that depends
+            // on it while running its initializers. Assuming that this is the only funny thing that the library does, there is
+            // a reasonable chance that nothing breaks, so just warn and continue.
+            dbgln("\033[33mWarning:\033[0m Querying for dependencies of '{}' while running its initializers", name);
+        }
+
         return;
+    }
 
     if (seen_names.contains(name))
         return;

Userland/Libraries/LibELF/DynamicLoader.cpp

@@ -243,6 +243,8 @@ Result<NonnullRefPtr<DynamicObject>, DlErrorMessage> DynamicLoader::load_stage_3
 #endif
     }
 
+    m_fully_relocated = true;
+
     return NonnullRefPtr<DynamicObject> { *m_dynamic_object };
 }
 

Userland/Libraries/LibELF/DynamicLoader.h

@@ -82,6 +82,7 @@ public:
 
     DynamicObject const& dynamic_object() const;
 
+    bool is_fully_relocated() const { return m_fully_relocated; }
     bool is_fully_initialized() const { return m_fully_initialized; }
 
 private:
@@ -161,6 +162,7 @@ private:
 
     mutable RefPtr<DynamicObject> m_cached_dynamic_object;
 
+    bool m_fully_relocated { false };
     bool m_fully_initialized { false };
 };