From 673a98258b23c2c3afc193178405ec52754e31ba Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 1 Aug 2019 14:01:37 +0200 Subject: [PATCH] GDirectoryModel: Fix redundant identical comparison. Found by PVS-Studio. --- Libraries/LibGUI/GDirectoryModel.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibGUI/GDirectoryModel.cpp b/Libraries/LibGUI/GDirectoryModel.cpp index bc454a33df..1e5fc334fc 100644 --- a/Libraries/LibGUI/GDirectoryModel.cpp +++ b/Libraries/LibGUI/GDirectoryModel.cpp @@ -158,9 +158,9 @@ GIcon GDirectoryModel::icon_for(const Entry& entry) const } else { thumbnail_cache().resource().set(path, nullptr); } + if (!entry.thumbnail) + return m_filetype_image_icon; } - if (!entry.thumbnail) - return m_filetype_image_icon; return GIcon(m_filetype_image_icon.bitmap_for_size(16), *entry.thumbnail); } return m_file_icon;