RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:17:44 +00:00
Code Issues Activity Actions

LibJS: Allow specifying only roundingIncrement in NumberFormat options

Browse source 
This is a normative change in the Intl.NumberFormat v3 spec. See:
a260aa3
This commit is contained in:
Timothy Flynn 2022-11-28 12:09:59 -05:00 • committed by Linus Groh
parent e3b8a8f7c8
commit 675e5bfdce
3 changed files with 27 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Tests/builtins/Intl/NumberFormat/NumberFormat.js
View file

@ -244,11 +244,7 @@ describe("errors", () => {
}).toThrowWithMessage(RangeError, "Value 5001 is NaN or is not between 1 and 5000");
expect(() => {
new Intl.NumberFormat("en", {
roundingIncrement: 3,
minimumFractionDigits: 2,
maximumFractionDigits: 2,
});
new Intl.NumberFormat("en", { roundingIncrement: 3 });
}).toThrowWithMessage(RangeError, "3 is not a valid rounding increment");
expect(() => {
@ -459,11 +455,7 @@ describe("normal behavior", () => {
[1, 2, 5, 10, 20, 25, 50, 100, 200, 250, 500, 1000, 2000, 2500, 5000].forEach(
roundingIncrement => {
expect(() => {
new Intl.NumberFormat("en", {
roundingIncrement: roundingIncrement,
minimumFractionDigits: 2,
maximumFractionDigits: 2,
});
new Intl.NumberFormat("en", { roundingIncrement: roundingIncrement });
}).not.toThrow();
}
);

6
Userland/Libraries/LibJS/Tests/builtins/Intl/NumberFormat/NumberFormat.prototype.resolvedOptions.js
View file

@ -348,11 +348,7 @@ describe("correct behavior", () => {
[1, 2, 5, 10, 20, 25, 50, 100, 200, 250, 500, 1000, 2000, 2500, 5000].forEach(
roundingIncrement => {
const en2 = new Intl.NumberFormat("en", {
roundingIncrement: roundingIncrement,
minimumFractionDigits: 2,
maximumFractionDigits: 2,
});
const en2 = new Intl.NumberFormat("en", { roundingIncrement: roundingIncrement });
expect(en2.resolvedOptions().roundingIncrement).toBe(roundingIncrement);
}
);