RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:17:44 +00:00
Code Issues Activity Actions

LibJS: Add and use the CreateNonEnumerableDataPropertyOrThrow AO

Browse source
This commit is contained in:
Idan Horowitz 2021-07-06 00:13:19 +03:00 • committed by Linus Groh
parent 6da7f43580
commit 6787e86a3a
5 changed files with 67 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/AggregateErrorConstructor.cpp
View file

@ -46,13 +46,11 @@ Value AggregateErrorConstructor::construct(FunctionObject& new_target)
if (vm.exception())
return {};
u8 attr = Attribute::Writable | Attribute::Configurable;
if (!vm.argument(1).is_undefined()) {
auto message = vm.argument(1).to_string(global_object);
if (vm.exception())
return {};
aggregate_error->define_property(vm.names.message, js_string(vm, message), attr);
aggregate_error->create_non_enumerable_data_property_or_throw(vm.names.message, js_string(vm, message));
}
aggregate_error->install_error_cause(vm.argument(2));
@ -63,7 +61,7 @@ Value AggregateErrorConstructor::construct(FunctionObject& new_target)
if (vm.exception())
return {};
aggregate_error->define_property(vm.names.errors, Array::create_from(global_object, errors_list), attr);
aggregate_error->define_property_or_throw(vm.names.errors, { .value = Array::create_from(global_object, errors_list), .writable = true, .enumerable = false, .configurable = true });
return aggregate_error;
}