RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:57:34 +00:00
Code Issues Activity Actions

LibELF: Remove outdated TLS handling in generic program header code

Browse source
This commit is contained in:
Tim Schumacher 2022-07-19 20:07:13 +02:00 • committed by Andreas Kling
parent 224ac1a307
commit 6799b271bf
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibELF/DynamicLoader.cpp
View file

@ -350,7 +350,6 @@ void DynamicLoader::load_program_headers()
Vector<ProgramHeaderRegion, 4> load_regions; Vector<ProgramHeaderRegion, 4> load_regions;
Vector<ProgramHeaderRegion, 3> map_regions; Vector<ProgramHeaderRegion, 3> map_regions;
Vector<ProgramHeaderRegion, 1> copy_regions; Vector<ProgramHeaderRegion, 1> copy_regions;
Optional<ProgramHeaderRegion> tls_region;
Optional<ProgramHeaderRegion> relro_region; Optional<ProgramHeaderRegion> relro_region;
VirtualAddress dynamic_region_desired_vaddr; VirtualAddress dynamic_region_desired_vaddr;
@ -359,8 +358,7 @@ void DynamicLoader::load_program_headers()
ProgramHeaderRegion region {}; ProgramHeaderRegion region {};
region.set_program_header(program_header.raw_header()); region.set_program_header(program_header.raw_header());
if (region.is_tls_template()) { if (region.is_tls_template()) {
VERIFY(!tls_region.has_value()); // Skip, this is handled in DynamicLoader::copy_initial_tls_data_into.
tls_region = region;
} else if (region.is_load()) { } else if (region.is_load()) {
if (region.size_in_memory() == 0) if (region.size_in_memory() == 0)
return; return;
@ -464,8 +462,6 @@ void DynamicLoader::load_program_headers()
memcpy(data_segment_start.as_ptr(), (u8*)m_file_data + region.offset(), region.size_in_image()); memcpy(data_segment_start.as_ptr(), (u8*)m_file_data + region.offset(), region.size_in_image());
} }
// FIXME: Initialize the values in the TLS section. Currently, it is zeroed.
} }
DynamicLoader::RelocationResult DynamicLoader::do_relocation(const ELF::DynamicObject::Relocation& relocation, ShouldInitializeWeak should_initialize_weak) DynamicLoader::RelocationResult DynamicLoader::do_relocation(const ELF::DynamicObject::Relocation& relocation, ShouldInitializeWeak should_initialize_weak)