RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:57:46 +00:00
Code Issues Activity Actions

AK: Standardize the behaviour of GenericLexer::consume_until overloads

Browse source 
Before this commit all consume_until overloads aside from the Predicate
one would consume (and ignore) the stop char/string, while the
Predicate overload would not, in order to keep behaviour consistent,
the other overloads no longer consume the stop char/string as well.
This commit is contained in:
Idan Horowitz 2022-01-24 23:47:22 +02:00 • committed by Ali Mohammad Pur
parent d49d2c7ec4
commit 67ce9e28a5
7 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/lsof.cpp
View file

@ -31,6 +31,7 @@ static bool parse_name(StringView name, OpenFile& file)
{
GenericLexer lexer(name);
auto component1 = lexer.consume_until(':');
lexer.ignore();
if (lexer.tell_remaining() == 0) {
file.name = component1;
@ -50,6 +51,7 @@ static bool parse_name(StringView name, OpenFile& file)
}
auto component3 = lexer.consume_until(')');
lexer.ignore();
if (lexer.tell_remaining() != 0) {
dbgln("parse_name: expected EOF");
return false;