RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

LibWeb: Use saved navigable pointer in destroy_the_child_navigable

Browse source 
During the destruction of a navigable, we need to use the pointer to
the navigable that was saved at the beginning of the function. This
is because `Node::navigable()` will return a nullptr in subsequent
steps after the navigable's document becomes inactive.
This commit is contained in:
Aliaksandr Kalenik 2023-09-05 23:05:44 +02:00 • committed by Andreas Kling
parent cf985afdcb
commit 67f5c027fe
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp
View file

@ -253,7 +253,7 @@ void NavigableContainer::destroy_the_child_navigable()
navigable->active_document()->destroy();
// 5. Let parentDocState be container's node navigable's active session history entry's document state.
auto parent_doc_state = this->navigable()->active_session_history_entry()->document_state;
auto parent_doc_state = navigable->active_session_history_entry()->document_state;
// 6. Remove the nested history from parentDocState's nested histories whose id equals navigable's id.
parent_doc_state->nested_histories().remove_all_matching([&](auto& nested_history) {
@ -261,7 +261,7 @@ void NavigableContainer::destroy_the_child_navigable()
});
// 7. Let traversable be container's node navigable's traversable navigable.
auto traversable = this->navigable()->traversable_navigable();
auto traversable = navigable->traversable_navigable();
// Not in the spec
navigable->set_has_been_destroyed();