RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:57:35 +00:00
Code Issues Activity Actions

LibWeb: Add the type field to DOM::Document

Browse source 
This patch adds the document type concept to documents and sets it in
various places.
This commit is contained in:
networkException 2022-07-03 21:44:00 +02:00 • committed by Linus Groh
parent baac3ba60c
commit 6805baeedd
5 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp
View file

@ -53,7 +53,6 @@ ExceptionOr<NonnullRefPtr<Document>> DOMImplementation::create_document(String c
// https://dom.spec.whatwg.org/#dom-domimplementation-createhtmldocument
NonnullRefPtr<Document> DOMImplementation::create_html_document(String const& title) const
{
// FIXME: This should specifically be a HTML document.
auto html_document = Document::create();
html_document->set_content_type("text/html");

15
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -45,6 +45,11 @@ class Document
public:
using WrapperType = Bindings::DocumentWrapper;
enum class Type {
XML,
HTML
};
static NonnullRefPtr<Document> create(const AK::URL& url = "about:blank")
{
return adopt_ref(*new Document(url));
@ -208,6 +213,12 @@ public:
bool in_quirks_mode() const { return m_quirks_mode == QuirksMode::Yes; }
void set_quirks_mode(QuirksMode mode) { m_quirks_mode = mode; }
Type document_type() const { return m_type; }
void set_document_type(Type type) { m_type = type; }
// https://dom.spec.whatwg.org/#xml-document
bool is_xml_document() const { return m_type == Type::XML; }
ExceptionOr<NonnullRefPtr<Node>> import_node(NonnullRefPtr<Node> node, bool deep);
void adopt_node(Node&);
ExceptionOr<NonnullRefPtr<Node>> adopt_node_binding(NonnullRefPtr<Node>);
@ -411,6 +422,10 @@ private:
NonnullRefPtrVector<HTML::HTMLScriptElement> m_scripts_to_execute_as_soon_as_possible;
QuirksMode m_quirks_mode { QuirksMode::No };
// https://dom.spec.whatwg.org/#concept-document-type
Type m_type { Type::HTML };
bool m_editable { false };
WeakPtr<Element> m_focused_element;

2
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -680,7 +680,7 @@ NonnullRefPtr<Node> Node::clone_node(Document* document, bool clone_children)
document_copy->set_content_type(document_->content_type());
document_copy->set_url(document_->url());
document_copy->set_origin(document_->origin());
// FIXME: Set type ("xml" or "html")
document_copy->set_document_type(document_->document_type());
document_copy->set_quirks_mode(document_->mode());
copy = move(document_copy);
} else if (is<DocumentType>(this)) {