RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:58:13 +00:00
Code Issues Activity Actions

Tests: Fix compile errors on Clang

Browse source 
Since Clang enables a couple of warnings that we don't have in GCC,
these were not caught before. Included fixes:

- Use correct printf format string for `size_t`
- Don't compare Nonnull(Ref|Own)Ptr` to nullptr
- Fix unsigned int& => unsigned long& conversion
This commit is contained in:
Daniel Bertalan 2021-07-13 16:23:39 +02:00 • committed by Andreas Kling
parent a88f7c99fe
commit 6821cd45ed
4 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibSQL/TestSqlDatabase.cpp
View file

@ -24,7 +24,6 @@ void insert_and_verify(int);
NonnullRefPtr<SQL::SchemaDef> setup_schema(SQL::Database& db)
{
auto schema = SQL::SchemaDef::construct("TestSchema");
EXPECT(schema != nullptr);
db.add_schema(schema);
return schema;
}
@ -33,7 +32,6 @@ NonnullRefPtr<SQL::SchemaDef> setup_table(SQL::Database& db)
{
auto schema = setup_schema(db);
auto table = SQL::TableDef::construct(schema, "TestTable");
EXPECT(table != nullptr);
db.add_table(table);
table->append_column("TextColumn", SQL::SQLType::Text);
table->append_column("IntColumn", SQL::SQLType::Integer);