RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:37:46 +00:00
Code Issues Activity Actions

LibJS: Implement Temporal.PlainTime.compare()

Browse source
This commit is contained in:
Idan Horowitz 2021-08-27 18:52:51 +03:00 • committed by Linus Groh
parent a77cdc5f92
commit 684e62476b
3 changed files with 32 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/Runtime/Temporal/PlainTimeConstructor.cpp
View file

@ -29,6 +29,7 @@ void PlainTimeConstructor::initialize(GlobalObject& global_object)
u8 attr = Attribute::Writable | Attribute::Configurable; u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.from, from, 1, attr); define_native_function(vm.names.from, from, 1, attr);
define_native_function(vm.names.compare, compare, 2, attr);
define_direct_property(vm.names.length, Value(0), Attribute::Configurable); define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
} }
@ -118,4 +119,21 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimeConstructor::from)
return to_temporal_time(global_object, item, *overflow); return to_temporal_time(global_object, item, *overflow);
} }
// 4.2.3 Temporal.PlainTime.compare ( one, two ), https://tc39.es/proposal-temporal/#sec-temporal.plaintime.compare
JS_DEFINE_NATIVE_FUNCTION(PlainTimeConstructor::compare)
{
// 1. Set one to ? ToTemporalTime(one).
auto* one = to_temporal_time(global_object, vm.argument(0));
if (vm.exception())
return {};
// 2. Set two to ? ToTemporalTime(two).
auto* two = to_temporal_time(global_object, vm.argument(1));
if (vm.exception())
return {};
// 3. Return 𝔽(! CompareTemporalTime(one.[[ISOHour]], one.[[ISOMinute]], one.[[ISOSecond]], one.[[ISOMillisecond]], one.[[ISOMicrosecond]], one.[[ISONanosecond]], two.[[ISOHour]], two.[[ISOMinute]], two.[[ISOSecond]], two.[[ISOMillisecond]], two.[[ISOMicrosecond]], two.[[ISONanosecond]])).
return Value(compare_temporal_time(one->iso_hour(), one->iso_minute(), one->iso_second(), one->iso_millisecond(), one->iso_microsecond(), one->iso_nanosecond(), two->iso_hour(), two->iso_minute(), two->iso_second(), two->iso_millisecond(), two->iso_microsecond(), two->iso_nanosecond()));
}
} }

1
Userland/Libraries/LibJS/Runtime/Temporal/PlainTimeConstructor.h
View file

@ -25,6 +25,7 @@ private:
virtual bool has_constructor() const override { return true; } virtual bool has_constructor() const override { return true; }
JS_DECLARE_NATIVE_FUNCTION(from); JS_DECLARE_NATIVE_FUNCTION(from);
JS_DECLARE_NATIVE_FUNCTION(compare);
}; };
} }

13
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.compare.js Normal file
View file

@ -0,0 +1,13 @@
describe("correct behavior", () => {
test("length is 2", () => {
expect(Temporal.PlainTime.compare).toHaveLength(2);
});
test("basic functionality", () => {
const plainTime1 = new Temporal.PlainTime(16, 38, 40, 1, 2, 3);
expect(Temporal.PlainTime.compare(plainTime1, plainTime1)).toBe(0);
const plainTime2 = new Temporal.PlainTime(16, 39, 5, 0, 1, 2);
expect(Temporal.PlainTime.compare(plainTime1, plainTime2)).toBe(-1);
expect(Temporal.PlainTime.compare(plainTime2, plainTime1)).toBe(1);
});
});