RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:05:08 +00:00
Code Issues Activity Actions

LibWeb: Improve support for "a" and "li" during "in body" insertion

Browse source 
We can now parse welcome.html once again, without resorting to hacks
or fallbacks during "in body" :^)
This commit is contained in:
Andreas Kling 2020-05-29 22:06:05 +02:00
parent 30d64fccde
commit 6854f726ce
4 changed files with 47 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Libraries/LibWeb/Parser/HTMLDocumentParser.cpp
View file

@ -623,10 +623,7 @@ void HTMLDocumentParser::run_the_adoption_agency_algorithm(HTMLToken& token)
PARSE_ERROR();
}
// FIXME: Let furthest block be the topmost node in the stack of open elements
// that is lower in the stack than formatting element, and is an element
// in the special category. There might not be one.
RefPtr<Element> furthest_block = nullptr;
RefPtr<Element> furthest_block = m_stack_of_open_elements.topmost_special_node_below(*formatting_element);
if (!furthest_block) {
while (&current_node() != formatting_element)
@ -642,7 +639,7 @@ void HTMLDocumentParser::run_the_adoption_agency_algorithm(HTMLToken& token)
TODO();
}
static bool is_special_tag(const FlyString& tag_name)
bool HTMLDocumentParser::is_special_tag(const FlyString& tag_name)
{
return tag_name.is_one_of(
"address",
@ -911,7 +908,17 @@ void HTMLDocumentParser::handle_in_body(HTMLToken& token)
}
if (token.is_end_tag() && token.tag_name() == "li") {
TODO();
if (!m_stack_of_open_elements.has_in_list_item_scope("li")) {
PARSE_ERROR();
return;
}
generate_implied_end_tags("li");
if (current_node().tag_name() != "li") {
PARSE_ERROR();
dbg() << "Expected <li> current node, but had <" << current_node().tag_name() << ">";
}
m_stack_of_open_elements.pop_until_an_element_with_tag_name_has_been_popped("li");
return;
}
if (token.is_end_tag() && token.tag_name().is_one_of("dd", "dt")) {
@ -943,7 +950,13 @@ void HTMLDocumentParser::handle_in_body(HTMLToken& token)
}
if (token.is_start_tag() && token.tag_name() == "a") {
TODO();
if (m_list_of_active_formatting_elements.last_element_with_tag_name_before_marker("a")) {
TODO();
}
reconstruct_the_active_formatting_elements();
auto element = insert_html_element(token);
m_list_of_active_formatting_elements.add(*element);
return;
}
if (token.is_start_tag() && token.tag_name().is_one_of("b", "big", "code", "em", "font", "i", "s", "small", "strike", "strong", "tt", "u")) {