LibGUI: Rename ModelClient::on_model_update() => model_did_update()

This follows the typical client callback naming scheme used elsewhere
and doesn't collide with the "on_foo" Function hook convention.

Applications/Browser/BookmarksBarWidget.cpp

@@ -108,7 +108,7 @@ void BookmarksBarWidget::resize_event(GUI::ResizeEvent& event)
     update_content_size();
 }
 
-void BookmarksBarWidget::on_model_update(unsigned)
+void BookmarksBarWidget::model_did_update(unsigned)
 {
     for (auto* child : child_widgets()) {
         child->remove_from_parent();

Applications/Browser/BookmarksBarWidget.h

@@ -32,9 +32,11 @@
 
 namespace Browser {
 
-class BookmarksBarWidget final : public GUI::Widget
+class BookmarksBarWidget final
+    : public GUI::Widget
     , private GUI::ModelClient {
-    C_OBJECT(BookmarksBarWidget)
+    C_OBJECT(BookmarksBarWidget);
+
 public:
     static BookmarksBarWidget& the();
 
@@ -54,7 +56,10 @@ public:
 private:
     BookmarksBarWidget(const String&, bool enabled);
 
-    virtual void on_model_update(unsigned) override;
+    // ^GUI::ModelClient
+    virtual void model_did_update(unsigned) override;
+
+    // ^GUI::Widget
     virtual void resize_event(GUI::ResizeEvent&) override;
 
     void update_content_size();

Applications/FileManager/DirectoryView.cpp

@@ -219,7 +219,7 @@ DirectoryView::~DirectoryView()
     m_model->unregister_client(*this);
 }
 
-void DirectoryView::on_model_update(unsigned flags)
+void DirectoryView::model_did_update(unsigned flags)
 {
     if (flags & GUI::Model::UpdateFlag::InvalidateAllIndexes) {
         for_each_view_implementation([](auto& view) {

Applications/FileManager/DirectoryView.h

@@ -37,7 +37,7 @@
 #include <LibGUI/TableView.h>
 #include <sys/stat.h>
 
-class LauncherHandler: public RefCounted<LauncherHandler> {
+class LauncherHandler : public RefCounted<LauncherHandler> {
 public:
     LauncherHandler(const NonnullRefPtr<Desktop::Launcher::Details>& details)
         : m_details(details)
@@ -51,9 +51,11 @@ private:
     NonnullRefPtr<Desktop::Launcher::Details> m_details;
 };
 
-class DirectoryView final : public GUI::StackWidget
+class DirectoryView final
+    : public GUI::StackWidget
     , private GUI::ModelClient {
-    C_OBJECT(DirectoryView)
+    C_OBJECT(DirectoryView);
+
 public:
     virtual ~DirectoryView() override;
 
@@ -118,7 +120,8 @@ private:
     DirectoryView();
     const GUI::FileSystemModel& model() const { return *m_model; }
 
-    virtual void on_model_update(unsigned) override;
+    // ^GUI::ModelClient
+    virtual void model_did_update(unsigned) override;
 
     void handle_activation(const GUI::ModelIndex&);
     GUI::ModelIndex map_table_view_index(const GUI::ModelIndex&) const;

Libraries/LibGUI/FilePicker.cpp

@@ -287,7 +287,7 @@ FilePicker::~FilePicker()
     m_model->unregister_client(*this);
 }
 
-void FilePicker::on_model_update(unsigned)
+void FilePicker::model_did_update(unsigned)
 {
     m_location_textbox->set_text(m_model->root_path());
     if (have_preview())

Libraries/LibGUI/FilePicker.h

@@ -35,8 +35,11 @@
 
 namespace GUI {
 
-class FilePicker final : public Dialog, private ModelClient {
+class FilePicker final
-    C_OBJECT(FilePicker)
+    : public Dialog
+    , private ModelClient {
+    C_OBJECT(FilePicker);
+
 public:
     enum class Mode {
         Open,
@@ -69,7 +72,8 @@ private:
 
     void set_path(const String&);
 
-    virtual void on_model_update(unsigned) override;
+    // ^GUI::ModelClient
+    virtual void model_did_update(unsigned) override;
 
     FilePicker(Window* parent_window, Mode type = Mode::Open, Options = Options::None, const StringView& file_name = "Untitled", const StringView& path = Core::StandardPaths::home_directory());
 

Libraries/LibGUI/Model.cpp

@@ -56,7 +56,7 @@ void Model::for_each_view(Function<void(AbstractView&)> callback)
 void Model::did_update(unsigned flags)
 {
     for (auto* client : m_clients)
-        client->on_model_update(flags);
+        client->model_did_update(flags);
 
     for_each_view([&](auto& view) {
         view.did_update_model(flags);

Libraries/LibGUI/Model.h

@@ -48,7 +48,7 @@ class ModelClient {
 public:
     virtual ~ModelClient() { }
 
-    virtual void on_model_update(unsigned flags) = 0;
+    virtual void model_did_update(unsigned flags) = 0;
 };
 
 class Model : public RefCounted<Model> {

Libraries/LibGUI/SortingProxyModel.cpp

@@ -50,7 +50,7 @@ SortingProxyModel::~SortingProxyModel()
     m_source->unregister_client(*this);
 }
 
-void SortingProxyModel::on_model_update(unsigned flags)
+void SortingProxyModel::model_did_update(unsigned flags)
 {
     resort(flags);
 }

Libraries/LibGUI/SortingProxyModel.h

@@ -57,7 +57,8 @@ public:
 private:
     explicit SortingProxyModel(NonnullRefPtr<Model> source);
 
-    virtual void on_model_update(unsigned) override;
+    // ^ModelClient
+    virtual void model_did_update(unsigned) override;
 
     Model& source() { return *m_source; }
     const Model& source() const { return *m_source; }