RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:07:45 +00:00
Code Issues Activity Actions

Kernel: Fix const-correctness of PCI::DeviceIdentifier usage

Browse source
This commit is contained in:
Andreas Kling 2023-02-19 23:14:42 +01:00
parent 053afbf2d1
commit 68c9781299
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Bus/PCI/Device.h
View file

@ -16,7 +16,7 @@ namespace Kernel::PCI {
class Device { class Device {
public: public:
DeviceIdentifier& device_identifier() const { return *m_pci_identifier; }; DeviceIdentifier const& device_identifier() const { return *m_pci_identifier; };
virtual ~Device() = default; virtual ~Device() = default;
@ -38,7 +38,7 @@ protected:
explicit Device(DeviceIdentifier const& pci_identifier); explicit Device(DeviceIdentifier const& pci_identifier);
private: private:
NonnullRefPtr<DeviceIdentifier> m_pci_identifier; NonnullRefPtr<DeviceIdentifier const> m_pci_identifier;
}; };
template<typename... Parameters> template<typename... Parameters>

4
Kernel/FileSystem/SysFS/Subsystems/Bus/PCI/DeviceDirectory.h
View file

@ -16,14 +16,14 @@ namespace Kernel {
class PCIDeviceSysFSDirectory final : public SysFSDirectory { class PCIDeviceSysFSDirectory final : public SysFSDirectory {
public: public:
static NonnullLockRefPtr<PCIDeviceSysFSDirectory> create(SysFSDirectory const&, PCI::DeviceIdentifier const&); static NonnullLockRefPtr<PCIDeviceSysFSDirectory> create(SysFSDirectory const&, PCI::DeviceIdentifier const&);
PCI::DeviceIdentifier& device_identifier() const { return *m_device_identifier; } PCI::DeviceIdentifier const& device_identifier() const { return *m_device_identifier; }
virtual StringView name() const override { return m_device_directory_name->view(); } virtual StringView name() const override { return m_device_directory_name->view(); }
private: private:
PCIDeviceSysFSDirectory(NonnullOwnPtr<KString> device_directory_name, SysFSDirectory const&, PCI::DeviceIdentifier const&); PCIDeviceSysFSDirectory(NonnullOwnPtr<KString> device_directory_name, SysFSDirectory const&, PCI::DeviceIdentifier const&);
NonnullRefPtr<PCI::DeviceIdentifier> m_device_identifier; NonnullRefPtr<PCI::DeviceIdentifier const> m_device_identifier;
NonnullOwnPtr<KString> m_device_directory_name; NonnullOwnPtr<KString> m_device_directory_name;
}; };