RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

LibGL: Don't crash on invalid pname value in glGetFloatv

Browse source 
This brings `glGetFloatv` more inline with the other `glGet`
functions. We should prevent crashing in the driver as much as
possible and instead let the application deal with the generated
GL error.
This commit is contained in:
Jesse Buhagiar 2021-08-19 21:16:17 +10:00 • committed by Andreas Kling
parent ca9619c750
commit 68d895eb7c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGL/SoftwareGLContext.cpp
View file

@ -1323,7 +1323,7 @@ void SoftwareGLContext::gl_get_floatv(GLenum pname, GLfloat* params)
default: default:
// FIXME: Because glQuake only requires GL_MODELVIEW_MATRIX, that is the only parameter // FIXME: Because glQuake only requires GL_MODELVIEW_MATRIX, that is the only parameter
// that we currently support. More parameters should be supported. // that we currently support. More parameters should be supported.
TODO(); RETURN_WITH_ERROR_IF(true, GL_INVALID_ENUM);
} }
} }