RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

LibGfx/JPEGWriter: Fix crash on macOS when csize coefficient is 0

Browse source 
This fixes #21108
This commit is contained in:
Nicolas Ramz 2023-10-06 11:55:20 +02:00 • committed by Andreas Kling
parent 80eec1e16b
commit 68e916490b
3 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/canvas/export.txt
View file

@ -1 +1,2 @@
1. "image/png" 1. "image/png"
2. "image/jpeg"

9
Tests/LibWeb/Text/input/canvas/export.html
View file

@ -13,10 +13,9 @@
}); });
// 2. Export a canvas to JPEG data URL // 2. Export a canvas to JPEG data URL
// FIXME: This fails on macOS: https://github.com/SerenityOS/serenity/issues/21108 testPart(() => {
// testPart(() => { const canvas = document.createElement('canvas');
// const canvas = document.createElement('canvas'); return canvas.toDataURL('image/jpeg').substring(5, 15);
// return canvas.toDataURL('image/jpeg').substring(5, 15); });
// });
}); });
</script> </script>

4
Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp
View file

@ -326,6 +326,10 @@ private:
static u8 csize(i16 coefficient) static u8 csize(i16 coefficient)
{ {
VERIFY(coefficient >= -2047 && coefficient <= 2047); VERIFY(coefficient >= -2047 && coefficient <= 2047);
if (coefficient == 0)
return 0;
return floor(log2(abs(coefficient))) + 1; return floor(log2(abs(coefficient))) + 1;
} }