RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

LibWeb: :checked should only match inputs in checkbox/radio type state

Browse source 
We were erroneously allowing :checked to match any input element.
This commit is contained in:
Andreas Kling 2022-03-16 23:29:17 +01:00
parent a403086940
commit 68f75ab98e
1 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/Libraries/LibWeb/CSS/SelectorEngine.cpp
View file

@ -26,6 +26,28 @@ static inline bool matches_hover_pseudo_class(DOM::Element const& element)
return element.is_ancestor_of(*hovered_node); return element.is_ancestor_of(*hovered_node);
} }
// https://html.spec.whatwg.org/multipage/semantics-other.html#selector-checked
static inline bool matches_checked_pseudo_class(DOM::Element const& element)
{
// The :checked pseudo-class must match any element falling into one of the following categories:
// - input elements whose type attribute is in the Checkbox state and whose checkedness state is true
// - input elements whose type attribute is in the Radio Button state and whose checkedness state is true
if (is<HTML::HTMLInputElement>(element)) {
auto const& input_element = static_cast<HTML::HTMLInputElement const&>(element);
switch (input_element.type_state()) {
case HTML::HTMLInputElement::TypeAttributeState::Checkbox:
case HTML::HTMLInputElement::TypeAttributeState::RadioButton:
return static_cast<HTML::HTMLInputElement const&>(element).checked();
default:
return false;
}
}
// FIXME: - option elements whose selectedness is true
return false;
}
static inline bool matches_attribute(CSS::Selector::SimpleSelector::Attribute const& attribute, DOM::Element const& element) static inline bool matches_attribute(CSS::Selector::SimpleSelector::Attribute const& attribute, DOM::Element const& element)
{ {
switch (attribute.match_type) { switch (attribute.match_type) {
@ -131,9 +153,7 @@ static inline bool matches_pseudo_class(CSS::Selector::SimpleSelector::PseudoCla
return false; return false;
return true; return true;
case CSS::Selector::SimpleSelector::PseudoClass::Type::Checked: case CSS::Selector::SimpleSelector::PseudoClass::Type::Checked:
if (!element.tag_name().equals_ignoring_case(HTML::TagNames::input)) return matches_checked_pseudo_class(element);
return false;
return static_cast<HTML::HTMLInputElement const&>(element).checked();
case CSS::Selector::SimpleSelector::PseudoClass::Type::Not: case CSS::Selector::SimpleSelector::PseudoClass::Type::Not:
for (auto& selector : pseudo_class.not_selector) { for (auto& selector : pseudo_class.not_selector) {
if (matches(selector, element)) if (matches(selector, element))